[WIP] Amélioration/modernisation du setup de test #1446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we keep specifying this in the .envrc, we'd have to also override it before each test run with MIX_ENV=test. If we remove it, test setup infers a default MIX_ENV=test.
antoine-de
reviewed
Jan 5, 2021
| @@ -32,4 +32,15 @@ defmodule TransportWeb.BuildTest do | |||
| {output, 0} = System.cmd("node", ["--version"]) | |||
| assert output |> String.trim() == "v" <> asdf_nodejs_release() | |||
| end | |||
|
|
|||
| def get_from(file) do | |||
There was a problem hiding this comment.
le nom de la fonction pourrait peut etre etre un peu plus explicit genre get_image (ou get_image_from_file) ?
|
Je reprends une partie de ces points dans #1673. Je garde la PR courante ouverte car il y d'autres choses à reprendre sur une PR différente. |
thbar
added a commit
that referenced
this pull request
Jul 8, 2021
thbar
added a commit
that referenced
this pull request
Jul 9, 2021
* Bump up Elixir & OTP to latest * Revert to version available as hex.pm image * Bump up base image + OTP & Elixir Hex.pm has published a new image, which has allowed me to release (https://github.com/etalab/transport-ops/releases/tag/elixir-1.12.1-erlang-24.0.3-alpine-3.13.3) a compatible image. * Fix base image reference * Trigger CI build * Update credo to latest and fix credo blockers * Fix postgrex-related Dialyzer warnings See elixir-ecto/postgrex#549 * Apply mix format * Remove warning during tests * Upgrade cowboy & ranch for OTP 24 compatibility (#1691) See https://ninenines.eu/docs/en/cowboy/2.9/guide/migrating_from_2.8/ This upgrades cowboy, cowlib, and also ranch. * Upgrade mochiweb to latest (OTP 24 compat) I had for now to work-around the lack of official hex.pm release (mochi/mochiweb#233). * Update Vex to master for Elixir 1.11 compat I also removed vex dependency for apps which did not depend on vex. * Bump up Elixir to 1.12.2 * Backport coveralls fixes from #1446 * Bump up coveralls * Fix credo warning & use fetch_env! instead of get for config * Skip credo issue for now * Fix regression after refactoring
|
J'ai tout réintégré dans #1683, je peux fermer celle-ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ne pas merger! Il y a des points pas clair du tout (régressions sur les tests), je reviendrai dessus plus tard.
PR avec différentes améliorations, suite à une séance de pairing (#1445) avec @fchabouis.
Eléments traités:
MIX_ENV:MIX_ENV=devdes fichiers locaux.envrcaprès cette PRMIX_ENV=testavant chaque opération liée aux tests (usage qui date de Elixir ~ v1.3 si j'ai compris)MIX_ENV=testpour les tâches de couverturesDockerfile.dev(que j'ai découvert) à la même version d'image que la prod (vite fait, sous forme d'un petit test)Dockerfile.devpour utiliserbetagouv/transport:0.4.5plutôt que la version0.4.3(abandonnée dans Mise à jour Elixir, Erlang & NodeJS #1363).Je ne fais qu'ouvrir en draft pour l'instant car il faudra que je vérifie avec du recul l'usage des DB, et passer en revue les différentes tâches, mais ça semble fonctionner à première vue.
En filigrane, ça nous amènera peut-être dans quelques temps à améliorer le temps de build sur le CI (éviter une double compilation dev/test), mais je n'en suis pas encore sûr.