Use holiday names from code du travail

[AntoineAugusti]

Dear reviewers,

We've got an important matter to discuss. France is watching us.

See discussion on data.gouv.fr. The question was: should we name bank holidays according to the code du travail or should we stick to names used by people?

Switching to names from code du travail

Pros:

• we don't have to pick names
• people have trouble to associate dates and names (When is Victoire des alliés again?)

Cons:

• it's a breaking change
• it's farther away from how people speak

To discuss:

• Rename methods?
• Document name <-> method mapping?

[abulte]

Like I said, I kinda like the "code du travail" names and it's an obvious way to justify our choices.

[geoffreyaldebert]

Very tough decision indeed...

I agree with choosing "code du travail" names.
If we want to be super precise, we could use two fields, one "nom_jour_ferie" related to "code du travail" and another one like "nom_usage_jour_ferie" related to "service-public" denomination.
But @AntoineAugusti I'm afraid to ask you that. I could take this on me after this is merge if you want.

[geoffreyaldebert]

Approved with remark of @abulte taking into account (changing function names)

[AntoineAugusti]

I updated all the method names, documented the mapping, bumped the version and added a CHANGELOG 😄