No longer returns ActiveRecord::NotFoundError for static entries #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skelz0r
requested review from
jbfeldis,
JeSuisUnCaillou,
Isalafont and
Samuelfaure
|
bon.. ça casse tout, pas ouf |
With an exception `ActiveRecord::NotFoundError` raised, rails handles this error within the controller as a 404 error, which seems legit for these kinds of error. However, with static content like forms, if we remove or rename/change forms we don't want to have a 404 error but a 500 error if it happens (better not to have error ofc, but best case is to catch it and fix it)
skelz0r
force-pushed
the
harden/static-content-not-found
branch
from
560d13f
to
8e2aed4
Compare
|
bon, c'était trivial à ficxer |
|
is it indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an exception
ActiveRecord::NotFoundErrorraised, rails handles this error within the controller as a 404 error, which seems legit for these kinds of error.However, with static content like forms, if we remove or rename/change forms we don't want to have a 404 error but a 500 error if it happens (better not to have error ofc, but best case is to catch it and fix it)