Merge pull request #1712 from etalab/scout/clean-useless-code

etalab · Oct 31, 2024 · 2db817d · 2db817d
2 parents 42bc40d + 631ee42
commit 2db817d
Show file tree

Hide file tree

Showing 14 changed files with 2 additions and 307 deletions.
diff --git a/app/interactors/user/notify_datapass_of_token_ownership.rb b/app/interactors/user/notify_datapass_of_token_ownership.rb
diff --git a/app/mailers/api_entreprise/user_mailer.rb b/app/mailers/api_entreprise/user_mailer.rb
diff --git a/app/mailers/api_particulier/user_mailer.rb b/app/mailers/api_particulier/user_mailer.rb
diff --git a/app/mailers/concerns/user_mailer_commons.rb b/app/mailers/concerns/user_mailer_commons.rb
diff --git a/app/organizers/api_entreprise/user/o_auth_login.rb b/app/organizers/api_entreprise/user/o_auth_login.rb
@@ -1,5 +1,4 @@
 class APIEntreprise::User::OAuthLogin < ApplicationOrganizer
   organize User::FindOrCreateThroughOAuth,
-    User::UpdateOAuthAPIGouvId,
-    User::NotifyDatapassOfTokenOwnership
+    User::UpdateOAuthAPIGouvId
 end
diff --git a/app/organizers/api_particulier/user/o_auth_login.rb b/app/organizers/api_particulier/user/o_auth_login.rb
@@ -1,5 +1,4 @@
 class APIParticulier::User::OAuthLogin < ApplicationOrganizer
   organize User::FindOrCreateThroughOAuth,
-    User::UpdateOAuthAPIGouvId,
-    User::NotifyDatapassOfTokenOwnership
+    User::UpdateOAuthAPIGouvId
 end
diff --git a/spec/features/api_entreprise/signin_process_datapass_spec.rb b/spec/features/api_entreprise/signin_process_datapass_spec.rb
@@ -63,12 +63,6 @@
           expect(user.oauth_api_gouv_id).to eq(unknown_api_gouv_id)
         end
 
-        it 'sends an email to DataPass to update the authorization request owner' do
-          expect { subject }
-            .to have_enqueued_mail(APIEntreprise::UserMailer, :notify_datapass_for_data_reconciliation)
-            .with(user, 'api_entreprise')
-        end
-
         it 'redirects to the user profile' do
           subject
 
@@ -79,11 +73,6 @@
       context 'when the user signs in the second time (and more)' do
         let!(:user) { create(:user) }
 
-        it 'does not send any email to DataPass' do
-          expect { subject }
-            .not_to have_enqueued_mail(APIEntreprise::UserMailer, :notify_datapass_for_data_reconciliation)
-        end
-
         it 'redirects to the user profile' do
           subject
 

diff --git a/spec/features/api_particulier/signin_process_datapass_spec.rb b/spec/features/api_particulier/signin_process_datapass_spec.rb
@@ -63,12 +63,6 @@
           expect(user.oauth_api_gouv_id).to eq(unknown_api_gouv_id)
         end
 
-        it 'sends an email to DataPass to update the authorization request owner' do
-          expect { subject }
-            .to have_enqueued_mail(APIParticulier::UserMailer, :notify_datapass_for_data_reconciliation)
-            .with(user, 'api_particulier')
-        end
-
         it 'redirects to the user profile' do
           subject
 
@@ -79,11 +73,6 @@
       context 'when the user signs in the second time (and more)' do
         let!(:user) { create(:user) }
 
-        it 'does not send any email to DataPass' do
-          expect { subject }
-            .not_to have_enqueued_mail(APIParticulier::UserMailer, :notify_datapass_for_data_reconciliation)
-        end
-
         it 'redirects to the user profile' do
           subject
 

diff --git a/spec/mailers/api_entreprise/user_mailer_spec.rb b/spec/mailers/api_entreprise/user_mailer_spec.rb
diff --git a/spec/mailers/api_particulier/user_mailer_spec.rb b/spec/mailers/api_particulier/user_mailer_spec.rb
diff --git a/spec/mailers/previews/api_entreprise/user_mailer_preview.rb b/spec/mailers/previews/api_entreprise/user_mailer_preview.rb
diff --git a/spec/mailers/previews/api_particulier/user_mailer_preview.rb b/spec/mailers/previews/api_particulier/user_mailer_preview.rb
diff --git a/spec/organizers/api_entreprise/user/o_auth_login_spec.rb b/spec/organizers/api_entreprise/user/o_auth_login_spec.rb
@@ -67,27 +67,5 @@
         expect(user.oauth_api_gouv_id).to eq(oauth_api_gouv_id)
       end
     end
-
-    context 'when the user signs in after receiving new tokens' do
-      let!(:user) { create(:user, :new_token_owner) }
-      let(:oauth_api_gouv_id) { user.oauth_api_gouv_id }
-
-      let(:another_sync) { described_class.call(params) }
-
-      it { is_expected.to be_a_success }
-
-      it 'sends an email to datapass for authorization request ownership update' do
-        expect { sync! }
-          .to have_enqueued_mail(APIEntreprise::UserMailer, :notify_datapass_for_data_reconciliation)
-          .with(user, 'api_entreprise')
-      end
-
-      it 'does not send emails on second login' do
-        another_sync
-
-        expect { sync! }
-          .not_to have_enqueued_mail(APIEntreprise::UserMailer, :notify_datapass_for_data_reconciliation)
-      end
-    end
   end
 end
diff --git a/spec/organizers/api_particulier/user/o_auth_login_spec.rb b/spec/organizers/api_particulier/user/o_auth_login_spec.rb
@@ -67,27 +67,5 @@
         expect(user.oauth_api_gouv_id).to eq(oauth_api_gouv_id)
       end
     end
-
-    context 'when the user signs in after receiving new tokens' do
-      let!(:user) { create(:user, :new_token_owner) }
-      let(:oauth_api_gouv_id) { user.oauth_api_gouv_id }
-
-      let(:another_sync) { described_class.call(params) }
-
-      it { is_expected.to be_a_success }
-
-      it 'sends an email to datapass for authorization request ownership update' do
-        expect { sync! }
-          .to have_enqueued_mail(APIParticulier::UserMailer, :notify_datapass_for_data_reconciliation)
-          .with(user, 'api_particulier')
-      end
-
-      it 'does not send emails on second login' do
-        another_sync
-
-        expect { sync! }
-          .not_to have_enqueued_mail(APIParticulier::UserMailer, :notify_datapass_for_data_reconciliation)
-      end
-    end
   end
 end