typescript compile error TS1479

[retorquere]

Describe the bug
When I try to import eta in my project with

import * as Eta from 'eta'

I get

error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("eta")' call instead.
  To convert this file to an ECMAScript module, change its file extension to '.mts', or add the field `"type": "module"` to 'package.json'.

To Reproduce

tsconfig.json:

{
  "compilerOptions": {
    "allowUnreachableCode": false,
    "noUnusedLocals": true,
    "isolatedModules": true,
    "esModuleInterop": true,
    "noUnusedParameters": false,
    "importHelpers": true,
    "target": "es2017",
    "disableSizeLimit": true,
    "module": "commonjs",
    "noImplicitAny": false,
    "removeComments": false,
    "preserveConstEnums": true,
    "sourceMap": false,
    "downlevelIteration": true,
    "resolveJsonModule": true,
    "moduleResolution": "node16",
    "skipLibCheck": true,
    "lib": [ "es2017", "dom", "dom.iterable", "webworker" ]
  },
  "include": [ "index.ts" ],
  "exclude": [ "node_modules" ]
}

index.ts:

import * as Eta from 'eta'
console.log(Eta)

package.json:

{
  "name": "tt",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "tsc --noemit"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "eta": "^1.13.0",
    "tslib": "^2.4.1",
    "typescript": "^4.9.4"
  }
}

type: npx tsc --noemit

Expected behavior

No error :)

Package & Environment Details

• Environment: Node
• Version: 18.9.0

[nebrelbug]

@retorquere interesting. Does this issue happen with [email protected]?

[retorquere]

Yes.

[retorquere]

It's the moduleResolution. If I set it to node instead of node16, the error goes away. But I've had it set to node16 for ages.

[nebrelbug]

@retorquere ok, I think the issue is that eta doesn't have a separate types file for eta.es.js and eta.cjs. I'm going to be updating Eta's build process, so I will try to fix this sometime (hopefully) in the next few days.

[nebrelbug]

@retorquere just published a new release which aims to improve NodeNext support. Will you check to see if it resolved the issue?

[DanSnow]

We still got an error when upgrading to 1.14.1 storipress/unplugin-eta#126

[retorquere]

For me the error is now gone, thanks!

[gurgunday]

We still got an error when upgrading to 1.14.1 storipress/unplugin-eta#126

Yeah, I can reproduce. PR is up.

[nebrelbug]

@retorquere I'm glad that worked!

@DanSnow I just merged @gurgunday's commit and published a new patch version, which should solve the problem.

[DanSnow]

@nebrelbug It's fixed. Thanks 🎉