-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create customers page #594
Create customers page #594
Conversation
Visit the preview URL for this PR (updated for commit 4fb0432): https://estuary-marketing--pr594-brenosalv-feature-35-8ujh0eum.web.app (expires Thu, 16 Jan 2025 18:18:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
…s to create various pages related to pagination?
<ButtonFilled onClick={handleShowMore}> | ||
Show more | ||
</ButtonFilled> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m considering using a ‘Show more’ button, similar to what we have on the author page, since there are currently only a few case studies. Implementing pagination with multiple pages at this stage would unnecessarily duplicate content across sections. Once we have a larger number of case studies, I’d consider adding proper pagination with ‘Previous’ and ‘Next’ buttons, like we do on the blog page. If you have any objection to this, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should not worry about this right now as we don't have too many. We could also just not use pagination and list them all the time like Connectors page does.
<li key="coalesce"> | ||
<StaticImage | ||
src="../../../images/customer-logos/coalesce.png" | ||
alt="Coalesce logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="flashpack"> | ||
<StaticImage | ||
src="../../../images/customer-logos/flashpack.svg" | ||
alt="Flash Pack logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="shp"> | ||
<StaticImage | ||
src="../../../images/customer-logos/shp.svg" | ||
alt="SHP logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="fenestra"> | ||
<StaticImage | ||
src="../../../images/customer-logos/fenestra.png" | ||
alt="Fenestra logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="deep-sync"> | ||
<StaticImage | ||
src="../../../images/customer-logos/deep-sync.png" | ||
alt="Deep Sync logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="excess-telecom"> | ||
<StaticImage | ||
src="../../../images/customer-logos/excess-telecom.png" | ||
alt="Excess Telecom logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="flock-freight"> | ||
<StaticImage | ||
src="../../../images/customer-logos/flock-freight.png" | ||
alt="Flock Freight logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="launch-metrics"> | ||
<StaticImage | ||
src="../../../images/customer-logos/launch-metrics.png" | ||
alt="Launch Metrics logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="chili-piper"> | ||
<StaticImage | ||
src="../../../images/customer-logos/chili-piper.png" | ||
alt="Chili Piper logo" | ||
{...commonProps} | ||
/> | ||
</li> | ||
<li key="revunit"> | ||
<StaticImage | ||
src="../../../images/customer-logos/revunit.png" | ||
alt="Revunit logo" | ||
{...commonProps} | ||
/> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's repeating because, as we know, the StaticImage does not accept dynamic values. Creating a component would pass the src as prop and it would not work - so just explaining.
src/components/Grid/Card/index.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reused the card component from the author page creating a separate component for it.
src/components/Grid/index.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Grid component was created to be reused in the author, blog and customers pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are now reusing the grid component in the popular articles section from the blog post page as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A SeeHowSection was created to reuse in the homepage, integration page and customers page with different buttons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…to Brenosalv/feature/351-new-customers-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
#351
Changes