Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize website colors into variables #591

Merged

Conversation

Brenosalv
Copy link
Collaborator

#476

Changes

  • Define variables for each color used in the code based on the Figma design. Extract the color values from Figma and assign them to named variables to ensure consistency and maintainability throughout the codebase.

@Brenosalv Brenosalv added the tech debt This is a task that really only the engineers notice label Dec 9, 2024
@Brenosalv Brenosalv self-assigned this Dec 9, 2024
@Brenosalv Brenosalv linked an issue Dec 9, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit f2318c2):

https://estuary-marketing--pr591-brenosalv-feature-47-nw5hw5dh.web.app

(expires Thu, 09 Jan 2025 01:55:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv Brenosalv marked this pull request as ready for review December 10, 2024 00:39
@Brenosalv
Copy link
Collaborator Author

Some colors are used only in specific cases, so I didn’t create variables for them. I added variables only for the most commonly used colors.

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - pulled the branch and searched for a few colors.

I think we will want to eventually remove a lot of the uses of variable colors that are one offs (or nearly one offs) with just changing the opacity on the end and force ourselves to only have between 3 and 5 versions of these. That way we can store them all in variables.

@travjenkins travjenkins merged commit 1ac48b3 into master Dec 10, 2024
15 checks passed
@travjenkins travjenkins deleted the Brenosalv/feature/476-organize-website-colors-into-variables branch December 10, 2024 03:03
@travjenkins travjenkins mentioned this pull request Dec 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt This is a task that really only the engineers notice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize website colors into variables
2 participants