-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize website colors into variables #591
Organize website colors into variables #591
Conversation
Visit the preview URL for this PR (updated for commit f2318c2): https://estuary-marketing--pr591-brenosalv-feature-47-nw5hw5dh.web.app (expires Thu, 09 Jan 2025 01:55:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
Some colors are used only in specific cases, so I didn’t create variables for them. I added variables only for the most commonly used colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - pulled the branch and searched for a few colors.
I think we will want to eventually remove a lot of the uses of variable colors that are one offs (or nearly one offs) with just changing the opacity on the end and force ourselves to only have between 3 and 5 versions of these. That way we can store them all in variables.
#476
Changes