Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo image URL #581

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

Brenosalv
Copy link
Collaborator

#570

Changes

  • Rename estuary logo.

Tests / Screenshots

image

@Brenosalv Brenosalv added the SEO Anything related to performance, SEO, Lighthouse, indexing, etc. label Nov 26, 2024
@Brenosalv Brenosalv self-assigned this Nov 26, 2024
@Brenosalv Brenosalv linked an issue Nov 26, 2024 that may be closed by this pull request
@Brenosalv
Copy link
Collaborator Author

Brenosalv commented Nov 26, 2024

@travjenkins Not sure if we should and can remove the hash from the end of the logo's name estuary-430cce9313e0df82d11e40d8285f38b4.png, but it's much better than combination-mark__multi-blue-430cce9313e0df82d11e40d8285f38b4.png. Thoughts?

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins
Copy link
Member

I don't think we need to remove the hash right now.

@Brenosalv
Copy link
Collaborator Author

I don't think we need to remove the hash right now.

Okay, so this is the best we can do. Please feel free to merge.

Copy link

Visit the preview URL for this PR (updated for commit 39aba30):

https://estuary-marketing--pr581-brenosalv-seo-570-up-wof05g33.web.app

(expires Thu, 26 Dec 2024 20:35:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@travjenkins travjenkins merged commit cda8a2b into master Nov 27, 2024
15 checks passed
@travjenkins travjenkins deleted the Brenosalv/seo/570-update-logo-image-url branch November 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SEO Anything related to performance, SEO, Lighthouse, indexing, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Logo Image URL
2 participants