Create deployment options page #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
Visit the preview URL for this PR (updated for commit 9e9b245): https://estuary-marketing--pr543-brenosalv-feature-51-9xdv0uvu.web.app (expires Sun, 24 Nov 2024 06:27:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
added 13 commits
October 17, 2024 14:34
…to Brenosalv/feature/513-deployment-options-page
…to Brenosalv/feature/513-deployment-options-page
added 2 commits
October 24, 2024 18:38
travjenkins
reviewed
Oct 25, 2024
| @@ -0,0 +1,23 @@ | |||
| export const features = { | |||
There was a problem hiding this comment.
Instead of having a stand alone list in the type DeploymentOption we should just reference this. That way it will always be in sync.
export type DeploymentOption = keyof typeof features;
There was a problem hiding this comment.
Makes sense, thanks.
travjenkins
reviewed
Oct 25, 2024
| <Seo | ||
| title="Estuary Flow Deployment Options: Public, Private & BYOC" | ||
| description="Estuary Flow offers Public, Private, and BYOC deployment options for secure, scalable, and customizable data integration, perfect for any business needs." | ||
| image={metaImg.childImageSharp.gatsbyImageData.images.fallback.src} |
travjenkins
reviewed
Oct 25, 2024
|
I created a container component and applied it to all the sections. I still need to do this for sections of the other pages. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#513
Changes
The path/slug is
/deployment-options.