Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security certificates section on the homepage #541

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Add security certificates section on the homepage #541

merged 9 commits into from
Oct 21, 2024

Conversation

Brenosalv
Copy link
Collaborator

@Brenosalv Brenosalv commented Oct 16, 2024 •
edited
Loading

#528

Changes

  • Add security certificates section below case studies section on the homepage.

Tests / Screenshots

Below the case sturdies section:
image

@Brenosalv Brenosalv added the enhancement New feature or request label Oct 16, 2024
@Brenosalv Brenosalv self-assigned this Oct 16, 2024
@Brenosalv Brenosalv linked an issue Oct 16, 2024 that may be closed by this pull request
Add security certs to main page #528
Closed
@Brenosalv
Copy link
Collaborator Author

Brenosalv commented Oct 16, 2024 •
edited
Loading

@danthelion Adding the security certificates section into the homepage conflicts the alternate background colors dark, light, dark, light, light... Is it okay for you? As now the number of sections is odd, there is no way to have alternative background colors as before. So I just set a darker grey background color to the new section.

image

@Brenosalv Brenosalv marked this pull request as ready for review October 16, 2024 21:47
@Brenosalv Brenosalv requested a review from travjenkins October 16, 2024 21:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6cdb34f):

https://estuary-marketing--pr541-brenosalv-feature-52-nrr982ga.web.app

(expires Wed, 20 Nov 2024 11:47:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@danthelion
Copy link

@Brenosalv that won't work, let's re-think how we add this again.

travjenkins
travjenkins reviewed Oct 18, 2024
View reviewed changes
src/components/Homepage/UseTheBestRealTimeCdc/index.tsx Outdated
@@ -14,7 +14,7 @@ import {
Wrapper,
} from './styles';

const SectionFour = () => {
const UseTheBestRealTimeCdc = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using react we should probably not start a component with use.

@Brenosalv Brenosalv requested a review from travjenkins October 21, 2024 14:34
travjenkins
travjenkins approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travjenkins travjenkins merged commit 19351a6 into master Oct 21, 2024
15 checks passed
@travjenkins travjenkins deleted the Brenosalv/feature/528-add-security-certs-to-main-page branch October 21, 2024 14:56
@Brenosalv Brenosalv mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees

@Brenosalv Brenosalv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add security certs to main page
3 participants
@Brenosalv @danthelion @travjenkins