-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: GA cors error #216
Fix: GA cors error #216
Conversation
Visit the preview URL for this PR (updated for commit 92ab965): https://estuary-marketing--pr216-fix-cors-errors-qr7nftnz.web.app (expires Fri, 12 Apr 2024 17:36:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
One issue with Partytown and GA is this break the testing tool : QwikDev/partytown#72 We should probably look into that a bit to see if there are any solutions/ideas/work arounds in that issue |
Get an error in the console when starting up the app locally
|
Since our GA script is completely down we can't check if it's happening to us, so I would suggest moving on to fix the problem we have now. what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some call outs and required changes
This tool is to be used locally.... I do not think this is impacted by the prod issue. |
it's connecting here, so we probably fine |
Moved GA to be hosted statically within the project like before since it's something that barely changes over the year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We'll need some stuff built out to make this a proper solution as a fast follow.
Do not merge until a full build/test deploy is double checked.
The build/test deployment is completed and healthy can we go for the merge? @travjenkins |
Changes
Tests / Screenshots
Lighthouse