Feat: Blog Posts new 3 column template #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d49aeb5): https://estuary-marketing--pr157-feat-blog-post-chang-uaxyxutx.web.app (expires Fri, 22 Dec 2023 20:09:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
Closed
2 tasks
travjenkins
reviewed
Mar 14, 2024
| <Link to={`/${article?.slug}`}>{article?.title}</Link> | ||
| </li> | ||
| </> | ||
| <li key={index}> |
There was a problem hiding this comment.
This should be switched to something like populate-articles__${article.slug}.
Then if the article is actually missing we should just return null as there is no reason to include the element if there is not an article.
travjenkins
reviewed
Mar 14, 2024
| <div className="table-of-contents"> | ||
| <ul> | ||
| {items.map((item, index) => ( | ||
| <li className={`${!item.root ? "sub-item" : ""} ${(index === 0 || item.position <= position) ? "active" : ""}`} key={index}> |
travjenkins
reviewed
Mar 14, 2024
| {item.children.map(child => ( | ||
| <NavMenuList item={child} /> | ||
| {item.children.map((child, index) => ( | ||
| <NavMenuList item={child} key={index} /> |
travjenkins
reviewed
Mar 14, 2024
| <Link | ||
| to={`/${post.Slug}`} | ||
| className="related-post-card" | ||
| key={index} |
travjenkins
reviewed
Mar 14, 2024
Comment on lines
+23
to
+34
| <div className="hero-image"> | ||
| {post.hero ? ( | ||
| <GatsbyImage | ||
| alt={post.title} | ||
| image={ | ||
| post.hero.localFile.childImageSharp | ||
| .gatsbyImageData | ||
| } | ||
| loading="eager" | ||
| /> | ||
| ) : null} | ||
| </div> |
There was a problem hiding this comment.
Is there a reason we are still including the div as empty when there is no hero image?
travjenkins
requested changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need this to change the Blog Posts template to 3 columns, including the new Related Posts layout and call to action buttons