Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flowctl-rs -> flowctl -> flowctl-go #384

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

psFried
Copy link
Member

@psFried psFried commented Mar 1, 2022

Description:

  • Renames the Go flowctl to flowctl-go
  • Renames the Rust flowctl-rs to flowctl

This completes the transition to the Rust-based flowctl as the single
user-facing CLI entrypoint. From this point on, all flowctl
subcommands will go through the Rust binary, which will delegate to
flowctl-go as needed.

Resolves #375
Completes the work started in #360.

Workflow steps:

Assuming everything is working correctly, there should be no difference for users. The flowctl commands that you've come to know and love will all continue to work. The --help text will look a little different, but that's about it.

Documentation links affected: None yet.

Notes for reviewers:

nada


This change is Reviewable

- Renames the Go `flowctl` to `flowctl-go`
- Renames the Rust `flowctl-rs` to `flowctl`

This completes the transition to the Rust-based flowctl as the single
user-facing CLI entrypoint. From this point on, all `flowctl`
subcommands will go through the Rust binary, which will delegate to
`flowctl-go` as needed.
@psFried psFried requested a review from willdonnelly March 1, 2022 15:44
Copy link
Member

@willdonnelly willdonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit 7c9cc5e into master Mar 1, 2022
@psFried psFried deleted the phil/long-live-flowctl branch March 1, 2022 18:31
@oliviamiannone oliviamiannone added the docs complete / NA No (more) doc work related to this PR label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs complete / NA No (more) doc work related to this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish flowctl-rs -> flowctl transition
3 participants