Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dekaf fixes #1745

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Small dekaf fixes #1745

merged 2 commits into from
Oct 29, 2024

Conversation

jshearer
Copy link
Contributor

@jshearer jshearer commented Oct 28, 2024

Description:

This pulls a few fixes out of #1738 in order to get them merged before we figure out the right way to do tinybird deletions

  • Remove the 64mb readback behavior as it wasn't the solution to lagged consumers, and seemed to be triggering some unexpected behavior in librdkafka when it tries to read at the high-watermark and gets a messageset with just a control doc in it (the ack for the transaction, which is almost always the last document available). This was causing intermittent issues with data preview UIs
  • Bump kafka-protocol to 0.13.0 and upgrade the Fetch API to support flexible versions. This fixes the warning about Message at offset xx might be too large to fetch, try increasing receive.message.max.bytes.

This change is Reviewable

…nd it is causing issues by allowing consumers to periodically read _just_ the last ack message
… support flexible versions.

I _believe_ this should fix the warning about `Message at offset xx might be too large to fetch, try increasing receive.message.max.bytes`.
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshearer jshearer merged commit ee70d45 into master Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants