materialize-snowflake: make account field optional #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake does not require an account query parameter in the connection string, so this change makes the account field optional. The go-snowflake driver's sf.DSN method for building the connection string can error out when an account isn't provided, so instead we build the connection string ourselves.
Alex-Bair
force-pushed
the
bair/sf-account-optional
branch
from
b420db5
to
3ab0f0f
Compare
Alex-Bair
added a commit
to estuary/flow
that referenced
this pull request
Jul 17, 2024
Update documentation for estuary/connectors#1725. Additionally, I reordered the properties in the Endpoint listing to reflect how the order in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Snowflake does not require an
accountquery parameter in the connection string, so this change makes theaccountinput optional. Thego-snowflakedriver'ssf.DSNmethod for building the connection string can error out whenaccountisn't provided, so instead we build the connection string ourselves.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
The Snowflake materialization docs will need updated to reflect that
accountis not required.Notes for reviewers:
Tested locally with:
hostURL formats<orgname>-<account_name>.snowflakecomputing.com<accountlocator>.<region>.<cloud>.snowflakecomputing.comThis change is