New branch for linkedin pages #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…44dd243a809340d8c1c Remote Repo URL: https://github.com/airbytehq/airbyte.git Source name: c613853d10700c60d2edd44dd243a809340d8c1c Source Commit ID: c613853d10700c60d2edd44dd243a809340d8c1c Source Repo Prefix: airbyte-integrations/connectors/source-linkedin-pages/ Import Path: source-linkedin-pages/ License Type: MIT License Path: ./airbyte-integrations/connectors/source-linkedin-pages/metadata.yaml git-merge-subpath: c613853d10700c60d2edd44dd243a809340d8c1c airbyte-integrations/connectors/source-linkedin-pages source-linkedin-pages
source-linkedin-pages: Fix schema null types source-linkedin-pages: Refactor LinkedIn API paths in source.py source-linkedin-pages: Format code with ruff and isort
…ifying tests: Add test capture files and credentials
Z33DD
force-pushed
the
source-linkedin-pages
branch
from
d29aa04 to
0284732
Compare
There was a problem hiding this comment.
The tests are broken - I think you need to update the snapshot tests for the added OAuth2 support. Also made some inline comments about minor URL related changes we need.
Other than that, this looks great, and I think is just about ready to merge. Before we merge it, please do a QA test along these lines:
- Work with @jonwihl to add the connector to our production supabase tables, using the image tag built from this pull request (which will be available when you fix the tests)
- Set up a capture using the connector through the UI on dashboard.estuary.dev. Make sure that data is captured as expected, and checkpoint resumption works as expected when you restart the task by disabling it and then re-enabling it through the UI. Make sure it works with all possible authentication methods.
- Materialize the collections captured by the connector and make sure everything works as expected. Use one of the SQL-based materializations. I'd suggest running a local postgres or mysql instance via docker and getting a public address using ngrok.
- After merging and the
v1image is pushed from themainbranch CI process, let @jonwihl know so he can update the version tag in supabase.
Also we need docs written for this. It is the developer's responsibility to put together docs for new connectors, or update docs based on changes. Please get a docs PR started against the estuary/flow repo and provide a link to that in this pull request. For an example of a docs pull request, see estuary/flow#1402
|
Also, please link the docs PR in this PR description under the "Documentation links affected:" header |
Z33DD
force-pushed
the
source-linkedin-pages
branch
from
0940c75 to
2abb9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This connector uses the old python connector method and not the Estuary CDK. There were numerous issues with module imports and expected paths. For instance:
The branch only contains one commit because of a bad rebase I made on the previous branch. For more detailed changes you can review wihl/python-linkedin-pages. Its all kinda a mess, let me know if its even worth merging in this state.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
See estuary/flow#1433
Notes for reviewers:
(anything that might help someone review this PR)
This change is