source-gladly: don't emit a checkpoint with no documents every time #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only emit an updated checkpoint when there are no documents if the current cursor is sufficiently old. Emitting a checkpoint with no documents will trigger an immediate re-invocation of the incremental task, so it shouldn't be done every time.
williamhbaker
force-pushed
the
wb/gladly-spam
branch
from
17c4bf5 to
cc138bd
Compare
jgraettinger
reviewed
Mar 5, 2024
| @@ -60,6 +60,15 @@ async def fetch_events( | |||
| f"not updating cursor since last_ts ({last_ts}) <= log_cursor ({log_cursor})" | |||
| ) | |||
| return | |||
| elif last_ts - log_cursor < timedelta(hours=6): | |||
There was a problem hiding this comment.
nit: i suspect this control flow could be cleaned up further, but this is correct 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Only emit an updated checkpoint when there are no documents if the current cursor is sufficiently old. Emitting a checkpoint with no documents will trigger an immediate re-invocation of the incremental task, so it shouldn't be done every time.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is