Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-gladly: new connector #1308

Merged
merged 2 commits into from
Mar 4, 2024
Merged

source-gladly: new connector #1308

merged 2 commits into from
Mar 4, 2024

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Mar 4, 2024

Description:

This is a very minimal connector that pulls data from the Gladly "events" API. Events are returned as a stream of JSONL objects with timestamps, which can be used to resume reading the stream upon a restart and is used with the "Incremental" mode of operation via the CDK.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@williamhbaker williamhbaker marked this pull request as ready for review March 4, 2024 20:01
@williamhbaker williamhbaker force-pushed the wb/source-gladly-final branch from 0a40231 to 2491970 Compare March 4, 2024 20:05
This is a very minimal connector that pulls data from the Gladly "events" API. Events are returned
as a stream of JSONL objects with timestamps, which can be used to resume reading the stream upon a
restart and is used with the "Incremental" mode of operation via the CDK.
@williamhbaker williamhbaker force-pushed the wb/source-gladly-final branch from 2491970 to 40c1126 Compare March 4, 2024 20:59
Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a pretty quick look and this appears to all match my understanding of how to use the CDK, so I say LGTM and let's get it out there

@williamhbaker williamhbaker merged commit 8e69ce3 into main Mar 4, 2024
49 of 53 checks passed
@williamhbaker williamhbaker deleted the wb/source-gladly-final branch March 4, 2024 21:08

id: str
type: str
timestamp: str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think timestamp should be a pydantic AwareDatetime, which is a standard datetime.datetime that's further constrained to have a timezone and renders its schemas a format: date-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants