Update logging

estherkim · Feb 14, 2019 · d69c38a · d69c38a
1 parent 7e4f701
commit d69c38a
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 13 deletions.
diff --git a/build-system/pr-check/build.js b/build-system/pr-check/build.js
@@ -45,7 +45,7 @@ const {getStderr} = require('../exec');
 const FILENAME = 'build.js';
 const FILELOGPREFIX = colors.bold(colors.yellow(`${FILENAME}:`));
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 /**
  * Prints a summary of files changed by, and commits included in the PR.

diff --git a/build-system/pr-check/checks.js b/build-system/pr-check/checks.js
@@ -31,7 +31,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'checks.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function main() {
   const startTime = startTimer(FILENAME);

diff --git a/build-system/pr-check/dist-test.js b/build-system/pr-check/dist-test.js
@@ -31,7 +31,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'dist-test.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function runSinglePassTest_() {
   timedExecOrDie('rm -R dist');

diff --git a/build-system/pr-check/local-test.js b/build-system/pr-check/local-test.js
@@ -31,7 +31,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'local-test.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function main() {
   const startTime = startTimer(FILENAME);

diff --git a/build-system/pr-check/remote-test.js b/build-system/pr-check/remote-test.js
@@ -33,7 +33,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'remote-test.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function main() {
   const startTime = startTimer(FILENAME);

diff --git a/build-system/pr-check/utils.js b/build-system/pr-check/utils.js
@@ -52,11 +52,12 @@ function stopSauceConnect(functionName) {
 /**
  * Starts a timer to measure the execution time of the given function.
  * @param {string} functionName
+ * @param {string} fileName
  * @return {DOMHighResTimeStamp}
  */
-function startTimer(functionName) {
+function startTimer(functionName, fileName) {
   const startTime = Date.now();
-  const fileLogPrefix = colors.bold(colors.yellow(`${functionName}:`));
+  const fileLogPrefix = colors.bold(colors.yellow(`${fileName}:`));
   console.log(
       '\n' + fileLogPrefix, 'Running', colors.cyan(functionName) + '...');
   return startTime;
@@ -95,12 +96,12 @@ function timedExec(cmd) {
  * Executes the provided command and times it. The program terminates in case of
  * failure.
  * @param {string} cmd
- * @param {string} functionName
+ * @param {string} fileName
  */
-function timedExecOrDie(cmd, functionName = 'utils.js') {
-  const startTime = startTimer(functionName);
+function timedExecOrDie(cmd, fileName = 'utils.js') {
+  const startTime = startTimer(cmd, fileName);
   execOrDie(cmd);
-  stopTimer(functionName, startTime);
+  stopTimer(fileName, startTime);
 }
 
 

diff --git a/build-system/pr-check/validator.js b/build-system/pr-check/validator.js
@@ -30,7 +30,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'validator.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function main() {
   const startTime = startTimer(FILENAME);

diff --git a/build-system/pr-check/visual-diff-test.js b/build-system/pr-check/visual-diff-test.js
@@ -32,7 +32,7 @@ const {isTravisPushBuild} = require('../travis');
 
 const FILENAME = 'visual-diff-test.js';
 const timedExecOrDie =
-  (cmd, unusedFunctionName) => timedExecOrDieBase(cmd, FILENAME);
+  (cmd, unusedFileName) => timedExecOrDieBase(cmd, FILENAME);
 
 function main() {
   const startTime = startTimer(FILENAME);