[Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299)

* change from type:gauge to type:top_n in inventory models * Add test for hostSystemOverview metric * fix lint errors Co-authored-by: Kibana Machine <[email protected]>
estermv · Jan 27, 2021 · 96e307b · 96e307b
1 parent 27a84d8
commit 96e307b
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 4 deletions.
diff --git a/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_docker_overview.ts b/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_docker_overview.ts
@@ -15,7 +15,7 @@ export const hostDockerOverview: TSVBMetricModelCreator = (
   index_pattern: indexPattern,
   interval,
   time_field: timeField,
-  type: 'gauge',
+  type: 'top_n',
   series: [
     {
       id: 'total',

diff --git a/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_k8s_overview.ts b/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_k8s_overview.ts
@@ -16,7 +16,7 @@ export const hostK8sOverview: TSVBMetricModelCreator = (
   index_pattern: indexPattern,
   interval,
   time_field: timeField,
-  type: 'gauge',
+  type: 'top_n',
   series: [
     {
       id: 'cpucap',

diff --git a/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_system_overview.ts b/x-pack/plugins/infra/common/inventory_models/host/metrics/tsvb/host_system_overview.ts
@@ -16,7 +16,7 @@ export const hostSystemOverview: TSVBMetricModelCreator = (
   index_pattern: indexPattern,
   interval,
   time_field: timeField,
-  type: 'gauge',
+  type: 'top_n',
   series: [
     {
       id: 'cpu',

diff --git a/x-pack/plugins/infra/common/inventory_models/shared/metrics/tsvb/aws_overview.ts b/x-pack/plugins/infra/common/inventory_models/shared/metrics/tsvb/aws_overview.ts
@@ -14,7 +14,7 @@ export const awsOverview: TSVBMetricModelCreator = (timeField, indexPattern): TS
   id_type: 'cloud',
   interval: '>=5m',
   time_field: timeField,
-  type: 'gauge',
+  type: 'top_n',
   series: [
     {
       id: 'cpu-util',

diff --git a/x-pack/test/api_integration/apis/metrics_ui/metrics.ts b/x-pack/test/api_integration/apis/metrics_ui/metrics.ts
@@ -93,5 +93,30 @@ export default function ({ getService }: FtrProviderContext) {
         expect(resp.metrics.length).to.equal(2);
       });
     });
+
+    it('should return multiple values for hostSystemOverview metric', () => {
+      const data = fetchNodeDetails({
+        sourceId: 'default',
+        metrics: ['hostSystemOverview'],
+        timerange: {
+          to: max,
+          from: min,
+          interval: '>=1m',
+        },
+        nodeId: 'demo-stack-mysql-01',
+        nodeType: 'host' as InfraNodeType,
+      });
+      return data.then((resp) => {
+        if (!resp) {
+          return;
+        }
+
+        const hostSystemOverviewMetric = resp.metrics.find(
+          (metric) => metric.id === 'hostSystemOverview'
+        );
+
+        expect(hostSystemOverviewMetric?.series.length).to.be.greaterThan(1);
+      });
+    });
   });
 }