Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws registry encryptionConfiguration to be applied #827

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

almoelda
Copy link
Contributor

Modified the CreateRepositoryInput structure for ECR registry according to the configuration.
Added the a default value for the EncryptionType and validation for the KmsKey key.

fixes #598

@estahn
Copy link
Owner

estahn commented Oct 29, 2024

@almoelda Can you check the tests?

@almoelda
Copy link
Contributor Author

almoelda commented Oct 29, 2024

@estahn Apologies for that. I've added the new default of EncryptionType (AES256) to the repository tests.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 27.79%. Comparing base (a086688) to head (f7721b4).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registry/ecr.go 0.00% 10 Missing ⚠️
pkg/config/config.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   28.04%   27.79%   -0.26%     
==========================================
  Files          11       11              
  Lines        1041     1054      +13     
==========================================
+ Hits          292      293       +1     
- Misses        724      736      +12     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@estahn estahn merged commit 04f18db into estahn:main Nov 19, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws encryptionConfiguration not being set with KMS
2 participants