Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): Add generic registry for source, not target #737

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rattboi
Copy link
Contributor

@rattboi rattboi commented May 29, 2024

This allows auth to a generic source registry, such as dockerhub.

This partially solves #50

This allows auth to a generic source registry, such as dockerhub.

This partially solves estahn#50
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 17.77778% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 28.60%. Comparing base (1bfe93a) to head (0f613c4).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/registry/generic.go 28.00% 18 Missing ⚠️
pkg/config/config.go 0.00% 11 Missing ⚠️
cmd/root.go 0.00% 3 Missing ⚠️
pkg/types/types.go 0.00% 3 Missing ⚠️
pkg/registry/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   29.24%   28.60%   -0.65%     
==========================================
  Files          11       12       +1     
  Lines         824      867      +43     
==========================================
+ Hits          241      248       +7     
- Misses        558      594      +36     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rattboi
Copy link
Contributor Author

rattboi commented May 29, 2024

Somehow I missed that this PR exists already:

#612

Any way we could get that one across the line? Currently running into dockerhub rate-limiting and really need to be able to auth k8s-image-swapper against docker.io

@estahn
Copy link
Owner

estahn commented Jun 3, 2024

Somehow I missed that this PR exists already:

Which one do you think makes more sense to look at?

I'm trying to find some time this week.

@rattboi
Copy link
Contributor Author

rattboi commented Jun 3, 2024

Somehow I missed that this PR exists already:

Which one do you think makes more sense to look at?

I'm trying to find some time this week.

I'd say definitely the other one. It does everything this one does, and more, and has better tests. It seems you've reviewed the other PR previously and there was just a papercut left.

If the OG author isn't receptive or has disappeared, and that's the only issue left, ping me and I'll pull their branch and make the changes so we can get this across the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants