Bump golang from 1.18 to 1.20 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@estahn, do you need anything from me? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
=======================================
Coverage 34.08% 34.08%
=======================================
Files 9 9
Lines 848 848
=======================================
Hits 289 289
Misses 534 534
Partials 25 25 ☔ View full report in Codecov by Sentry. |
|
I am mostly offline until after Thanksgiving, but I will take a look at the failures when I am back if it is still an issue. |
|
@krmichelos Thanks. I'm travelling over the next couple of weeks, so have limited time myself. |
krmichelos
force-pushed
the
main
branch
2 times, most recently
from
82b55cf
to
745936d
Compare
|
@estahn I believe I have all the lint related issues resolved |
|
@estahn, I know it is a busy time of year, but would you be able to approve the tests to run so I can see if they pass? |
|
I will be mostly unavailable until after the new year |
estahn
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang 1.20 is the oldest version that is supported