-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening hours not working #631
Comments
hey @neel8440924 if you could please try this new PR here: #632 it might have fixed the problem. Also, can you please check in the Settings -> NTP settings if the hour displayed is correct? |
I can also confirm issue #631, it still trigger the relay even if I disable the access on Tuesday :
PR #632 seems to fix this issue :
|
I have tested this PR #632 for some time, but I don't know I think the problem is still there, I have noticed sometimes it deny access even in opening hours also, I was not able to test it fully as it was causing problem for the users so I am not using this feature for now, maybe others can test it more and report back. |
@neel8440924 we are using this feature daily with hundreds of people and it works. The only issue that I had was with losing connection with the NTP server. If you lose that connection, then the esp can drift quite quickly and have a time very far from reality. So if you (or someone else) want to try this feature more and if you have problems, please also attach the logs of the accesses, so that we can see at what time the access has been denied and we can check if the reason is the time drift. Thanks! |
@matjack1 I have created a test setup to check it in a more controlled way and mess with settings without affecting other people. Herein this example , it denies access even in opening hours. I have attached screenshot of general setting, NTP setting, user setting as well as access logs |
hey @neel8440924 I'm very sorry for the delay here, I've just merged in the |
I am using build 173 with rc522 reader. Opening hours setting not working, non admin tag can activate relay and open door in non working hours(unticked hours) and log also shows access granted?
The text was updated successfully, but these errors were encountered: