Rewrite coordinates folding of virtual sites relative #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rudolf Weeber <[email protected]>
Particles tracked by relative virtual sites need to communicate their image_box to ensure proper coordinates folding when the virtual site gets the real particle information from a ghost layer.
RudolfWeeber
approved these changes
Apr 14, 2023
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Apr 14, 2023
Fixes espressomd#4703 Description of changes: - bugfix: virtual sites relative are now properly folded again (the regression was introduced by espressomd#4564) - bugfix: uninitialized virtual sites now throw a runtime error instead of implicitly tracking the particle with pid=0 - write more thorough tests for virtual sites relative: integration through periodic boundaries, checkpointing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4703
Description of changes: