Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose local_particles only thru function calls #3501

Merged
merged 7 commits into from
Feb 18, 2020
Merged

Expose local_particles only thru function calls #3501

merged 7 commits into from
Feb 18, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Feb 18, 2020

  • Access local_particles (local particle map) by functions instead of directly
  • Removed unused code
  • Simplified PartCfg

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #3501 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3501   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         534     534           
  Lines       24357   24357           
======================================
- Hits        21204   21203    -1     
- Misses       3153    3154    +1
Impacted Files Coverage Δ
src/core/global.cpp 83% <ø> (ø) ⬆️
src/core/particle_data.hpp 100% <ø> (ø) ⬆️
src/core/particle_data.cpp 96% <ø> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (-1%) ⬇️
src/core/polymer.cpp 98% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836d921...f2524b7. Read the comment docs.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI

@fweik
Copy link
Contributor Author

fweik commented Feb 18, 2020

Unfortunately now clang-tidy can analyze the code ^^

@jngrad jngrad added this to the Espresso 4.2 milestone Feb 18, 2020
@fweik fweik added the automerge Merge with kodiak label Feb 18, 2020
@kodiakhq kodiakhq bot merged commit 7e43d59 into espressomd:python Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants