Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fixed erronous feature guards in P3M, fixed missing feature dec… #3403

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Jan 7, 2020

…larations in tests

Fixes #3401

@fweik fweik requested a review from jngrad January 7, 2020 14:31
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #3403 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3403    +/-   ##
=======================================
+ Coverage      86%     86%   +<1%     
=======================================
  Files         538     538            
  Lines       25250   25250            
=======================================
+ Hits        21773   21774     +1     
+ Misses       3477    3476     -1
Impacted Files Coverage Δ
...re/electrostatics_magnetostatics/p3m_send_mesh.cpp 100% <ø> (ø) ⬆️
...re/electrostatics_magnetostatics/p3m_send_mesh.hpp 100% <ø> (ø) ⬆️
src/core/particle_data.cpp 97% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c8f2a...06945f9. Read the comment docs.

@fweik fweik added the automerge Merge with kodiak label Jan 7, 2020
@kodiakhq kodiakhq bot merged commit 9b69e75 into espressomd:python Jan 7, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone Jan 7, 2020
@jngrad jngrad added the Core label Jan 7, 2020
@fweik fweik deleted the dipoles_ branch January 22, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with feature DIPOLES but without ELECTROSTATICS fails
2 participants