Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Fixed bitwise comparison of floating point numbers #3327

Merged
merged 1 commit into from
Nov 20, 2019
Merged

core: Fixed bitwise comparison of floating point numbers #3327

merged 1 commit into from
Nov 20, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Nov 19, 2019

Partial fix for #3315.

@fweik fweik requested a review from KaiSzuttor November 19, 2019 13:35
@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #3327 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3327   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         538     538           
  Lines       25346   25346           
======================================
- Hits        21832   21827    -5     
- Misses       3514    3519    +5
Impacted Files Coverage Δ
src/core/unit_tests/MpiCallbacks_test.cpp 100% <100%> (ø) ⬆️
src/utils/tests/matrix_vector_product.cpp 100% <100%> (ø) ⬆️
src/core/particle_data.cpp 96% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d0ed2...c5e3795. Read the comment docs.

@fweik fweik added this to the 4.1.2 milestone Nov 19, 2019
@fweik
Copy link
Contributor Author

fweik commented Nov 20, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 20, 2019
@bors @fweik
Merge #3327
c91ea5e 
3327: core: Fixed bitwise comparison of floating point numbers r=fweik a=fweik

Partial fix for #3315.


Co-authored-by: Florian Weik <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 20, 2019

Build succeeded

@bors bors bot merged commit c5e3795 into espressomd:python Nov 20, 2019
@jngrad jngrad mentioned this pull request Jan 21, 2020
Closed
@fweik fweik deleted the bitwise branch August 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
BugFix Core
Projects
None yet
Milestone
Espresso 4.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@fweik @KaiSzuttor