Core: do_non_bonded, capture by reference rather than value #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
approved these changes
Sep 12, 2019
|
@RudolfWeeber was this in a debug built? |
Codecov Report
@@ Coverage Diff @@
## python #3161 +/- ##
======================================
- Coverage 85% 85% -1%
======================================
Files 526 526
Lines 25994 25946 -48
======================================
- Hits 22118 22066 -52
- Misses 3876 3880 +4
Continue to review full report at Codecov.
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 12, 2019
3155: Fix regressions found by exotic archs r=KaiSzuttor a=jngrad Part of the [release checklist](https://github.com/espressomd/espresso/wiki/release-checklist#for-all-releases): run tests on exotic architectures and intel compiler. 3161: Core: do_non_bonded, capture by reference rather than value r=jngrad a=RudolfWeeber This fixes a performance regression from #3077, I think. Time per step fro lj benchmark went down from 0.78 to 0.38 ms 3162: Cleanup LB global variables r=KaiSzuttor a=jngrad Follow-up to #2628 Description of changes: - removed unused global variables in LB code - cleaned up documentation Co-authored-by: Jean-Noël Grad <[email protected]> Co-authored-by: Rudolf Weeber <[email protected]>
|
was this in a debug built?
No. First thing I checked.
Would you have expected the compiler to figure out that the copy wasn’t needed?
|
|
Yes, because |
|
Btw this should only capture the id, not the whole particle. This would also have avoided the regression... std::none_of(p1.el.begin(), p1.el.end(),
[id2 = p2.p.identity](int id) { return id2 == id; }); |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression from #3077, I think.
Time per step fro lj benchmark went down from 0.78 to 0.38 ms