Removed from __future__ #3008
Merged
Removed from __future__ #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
approved these changes
Jul 25, 2019
|
bors r+ |
|
There is some more Py2-specific code, mainly the use of the six module, the unicode C string wrapper and the Cython 2/3 flags in CMake. That should be removed too. |
bors bot
added a commit
that referenced
this pull request
Jul 25, 2019
2939: Documentation of VV, NPT, Thermostats r=RudolfWeeber a=christophlohrmann Fixes #2680 Description of changes: - Added sphinx documentation for velocity verlet, NPT - Added/Updated sphinx documentation for Langevin, NPT, LB, DPD thermostat - Found some papers as reference PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [x] Docs? 3006: Reduce usage of local cells r=fweik a=KaiSzuttor Fixes part of #2899 Description of changes: - replacement for #2991 3008: Removed from __future__ r=jngrad a=jrfinkbeiner Fixes #3004 3015: Update checkpointing docs r=jngrad a=RudolfWeeber Fixes #2808 Co-authored-by: Christoph Lohrmann <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]> Co-authored-by: Kai Szuttor <[email protected]> Co-authored-by: Alexander Reinauer <[email protected]> Co-authored-by: Jan Finkbeiner <[email protected]> Co-authored-by: Rudolf Weeber <[email protected]>
Codecov Report
@@ Coverage Diff @@
## python #3008 +/- ##
======================================
Coverage 82% 82%
======================================
Files 525 525
Lines 26740 26740
======================================
Hits 22014 22014
Misses 4726 4726Continue to review full report at Codecov.
|
Timed out (retrying...) |
1 similar comment
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 25, 2019
3008: Removed from __future__ r=jngrad a=jrfinkbeiner Fixes #3004 3015: Update checkpointing docs r=jngrad a=RudolfWeeber Fixes #2808 Co-authored-by: Jan Finkbeiner <[email protected]> Co-authored-by: Rudolf Weeber <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
Build succeeded |
Merge conflict (retrying...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3004