-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some code duplication #2697
Conversation
…this causes a warning.
Codecov Report
@@ Coverage Diff @@
## python #2697 +/- ##
=======================================
+ Coverage 79% 79% +<1%
=======================================
Files 506 508 +2
Lines 27038 27050 +12
=======================================
+ Hits 21484 21496 +12
Misses 5554 5554
Continue to review full report at Codecov.
|
This does not work with HIP, but the error message is not really helpful... |
@KaiSzuttor the HIP stuff could be fixed, I also replaced the constant macros that collided with walberla (and should have been replaced anyway). |
by making some utils math functions usable on the gpu.
Also replaced the macro constants by functions, also for gpu.