Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip long-running (timeout-prone) tests on exotic archs #2641

Merged

Conversation

RudolfWeeber
Copy link
Contributor

No description provided.

@RudolfWeeber
Copy link
Contributor Author

How can I manually trigger the exotic arch tests for this?

@RudolfWeeber RudolfWeeber mentioned this pull request Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #2641 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2641   +/-   ##
======================================
- Coverage      79%     79%   -1%     
======================================
  Files         497     497           
  Lines       27105   27105           
======================================
- Hits        21426   21425    -1     
- Misses       5679    5680    +1
Impacted Files Coverage Δ
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c78484...97c942c. Read the comment docs.

@mkuron
Copy link
Member

mkuron commented Apr 3, 2019

This is a terrible solution. The tests should be fixed, not skipped.

@KaiSzuttor
Copy link
Member

it's an intermediate solution

@KaiSzuttor KaiSzuttor merged commit 3283344 into espressomd:python Apr 4, 2019
@RudolfWeeber
Copy link
Contributor Author

While I understand the discomfort, as long as no PR with a better solution is provided,
this PR aims to resolve an untenable situation keeping most of the tests on uncommen architectures.
Except for coulomb_tuning, all tests exlucded here run in less than 10 seconds on my desktop. P3m_Tuning takes 21 seconds.
So the tests are not inherently over the top in terms of computational effort.

I'll gladly withdraw this PR, if there is an alternative one solving the frequent false-positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants