Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracy in the lattice boltzmann tutorial #4804

Closed
sH4MbLe5 opened this issue Oct 11, 2023 · 1 comment
Closed

Inaccuracy in the lattice boltzmann tutorial #4804

sH4MbLe5 opened this issue Oct 11, 2023 · 1 comment

Comments

@sH4MbLe5
Copy link

In espressomd/espresso/tree/python/doc/tutorials/lattice_boltzmann/lattice_boltzmann_sedimentation.ipynb
the 'dist' parameter of the espressomd.shapes.Wall object should be set to spacing not to 1.

@jngrad
Copy link
Member

jngrad commented Oct 16, 2023

Thank you for your feedback. As far as I remember, this spacing value was deliberately chosen such that the ceiling wall wouldn't exert a non-bonded force on the top layer of the particle cloud during the first time step. For the LB algorithm, the distance is actually rounded down, thus a distance of 1.0 or 1.22 will in either case create a LB boundary of thickness 1. The user guide doesn't seem to mention this rounding-down feature, though. I've opened a PR to add a paragraph to that effect (see 99f4275d:doc/sphinx/lb.rst).

kodiakhq bot added a commit that referenced this issue Oct 17, 2023
Description of changes:
- remove summer school banner
- make the ELC tutorial appear on GitHub Pages
- document effect of lattice offset on shape-based constraints used to create boundaries (follow-up to #4804)
@jngrad jngrad closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants