-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thermalization of CPU LB broken #3804
Comments
Can you please check in Ulf Schillers PhD thesis what are the expectation values for
<sigma_{ij}^2> for thermalized lb?
What are the integrals of the stress acf for cpu and gpu, respectively?
|
With gpu the acf integral produces ~ resonable values for the viscosity via Green-Kubo, for cpu, the acf does not even decay yet (~1e6 |
Concerning Ulfs PhD thesis, I have not yet had to much to do with it, apart from browsing a bit and I am thus not immediately familiar with the different notations and definitions used there. Will give it a try, however, it will probably be a lot faster, if someone more involved with this, e.g. @mkuron or @KaiSzuttor could comment... |
In offline discussion, @RudolfWeeber suggested that this issue might be a regression. I checked for ESPResSo version 4.1.0, same problem, for 4.0.0 there doesn't seem to be a fluid stress observable (neither |
How do you know that the issue has been around for some time if you cannot check for versions older than 4.1.0 (which is less than a year old)? |
Let me rephrase that: |
Fixes #3804 , fixes #3772 The issue was actually a regression that happened with the switch to philox in commit [f3cc4ba](f3cc4ba). Random numbers formerly part of the interval (-0.5,0.5] were replaced by random numers in (0,1]. With this fix the `lb_pressure_tensor_acf.py` runs successfully for both CPU and GPU. However, as @KaiSzuttor correctly mentioned in PR #3831 the CPU part of the test takes a while to execute (on my machine, single core the whole test takes 136 s). I could try to make that faster which, however, would require tweaking the tolerance limits `tol_node` and `tol_global`. @RudolfWeeber , what was your reasoning behind the chosen limits? Or are they semi-arbitrary choices? Further, this PR corrects the comparison of the off-diagonal elements `avg_ij` vs. `avg_ji` in the test.
Fixes espressomd#3804 , fixes espressomd#3772 The issue was actually a regression that happened with the switch to philox in commit [f3cc4ba](espressomd@f3cc4ba). Random numbers formerly part of the interval (-0.5,0.5] were replaced by random numers in (0,1]. With this fix the `lb_pressure_tensor_acf.py` runs successfully for both CPU and GPU. However, as @KaiSzuttor correctly mentioned in PR espressomd#3831 the CPU part of the test takes a while to execute (on my machine, single core the whole test takes 136 s). I could try to make that faster which, however, would require tweaking the tolerance limits `tol_node` and `tol_global`. @RudolfWeeber , what was your reasoning behind the chosen limits? Or are they semi-arbitrary choices? Further, this PR corrects the comparison of the off-diagonal elements `avg_ij` vs. `avg_ji` in the test.
IMHO broken for CPU. Minimal example:
Testing via
run_minimal.sh
:yields:
kT=0
case is fine, but with thermalization, CPU produces off-dagonal pressure values of orderThe text was updated successfully, but these errors were encountered: