Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve virtual sites and topology handling #232

Closed
fweik opened this issue Apr 21, 2015 · 2 comments
Closed

Improve virtual sites and topology handling #232

fweik opened this issue Apr 21, 2015 · 2 comments

Comments

@fweik
Copy link
Contributor

fweik commented Apr 21, 2015

Thu 22 Mar 2012 06:02:32 PM CET, original submission:
VIRTUAL_SITES_RELATIVE and VIRTUAL_SITES_COM are implemented in opposite ways.
VIRTUAL_SITES_RELATIVE uses particle properties, while VIRTUAL_SITES_COM uses the topology data.
The first approach seems easy to generalize, however for many molecule the second one save memory as every molecule data is only stores once.
Also the setup is very different VIRTUAL_SITES_RELATIVE uses the part command, while VIRTUAL_SITES_COM uses the "analyze set" command.
The first one is more obvious to use as there is no documentation for the second one ("analyze set chain" is documented, but this is something else).
The suggestion would be to make both accessible via the part command under a "vs" sub-command:
part ... vs relative ...
part ... vs relative_auto ...
part ... vs com ...
With this we can disallow the direct setting of the virtual property via the "part .. virtual {0|1}" command.
Additionally the "analyze set" could be reworked into a topology command:
topology create mol_id parts id id id type int excl {0|1}
topology delete mol_id
topology create mol_id chain ....
With this we can disallow the direct setting of the mol_id property via the "part .. mol_id id" command.

@fweik fweik added the Todo label May 5, 2015
fweik pushed a commit that referenced this issue Jan 29, 2019
@jngrad
Copy link
Member

jngrad commented Oct 15, 2019

2019 update: feature VIRTUAL_SITES_COM is not functional anymore and will be removed in #3250.

@fweik
Copy link
Contributor Author

fweik commented Oct 15, 2019

This is not relevant anymore, the (molecule)-topology system does not exist anymore, neither does virtual sites com.

@fweik fweik closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants