Skip to content

Commit

Permalink
DevOps: Bump version requirements
Browse files Browse the repository at this point in the history
Require CMake 3.20. Use new ScaFaCoS build. Handle known Doxygen bug.
On the espressomd/espresso repository, only write a CI cache file on
push from the main branch.
  • Loading branch information
jngrad committed May 4, 2023
1 parent 711a17c commit 47b95a0
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/push_pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
uses: hendrikmuhs/[email protected]
with:
key: macos
save: ${{ ! startsWith(github.ref, 'refs/pull') }}
save: ${{ github.ref == 'refs/heads/python' }}
- name: Setup Python environment
uses: actions/[email protected]
with:
Expand All @@ -35,7 +35,7 @@ jobs:
debian:
runs-on: ubuntu-latest
container:
image: ghcr.io/espressomd/docker/debian:f6cf74049a2521b2b5580d23d42c8290c5f7611e-base-layer
image: ghcr.io/espressomd/docker/debian:fbdf2f2f9d76b761c0aa1308f17fb17e38501850-base-layer
credentials:
username: ${{ github.actor }}
password: ${{ secrets.github_token }}
Expand All @@ -47,7 +47,7 @@ jobs:
uses: hendrikmuhs/[email protected]
with:
key: debian
save: ${{ ! startsWith(github.ref, 'refs/pull') }}
save: ${{ github.ref == 'refs/heads/python' || ( github.repository != 'espressomd/espresso' && ! startsWith(github.ref, 'refs/pull') ) }}
- name: Setup Git environment
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Get runner specifications
Expand All @@ -74,7 +74,7 @@ jobs:
runs-on: ubuntu-latest
if: ${{ github.repository == 'espressomd/espresso' }}
container:
image: ghcr.io/espressomd/docker/ubuntu-wo-dependencies:f6cf74049a2521b2b5580d23d42c8290c5f7611e-base-layer
image: ghcr.io/espressomd/docker/ubuntu-wo-dependencies:fbdf2f2f9d76b761c0aa1308f17fb17e38501850-base-layer
credentials:
username: ${{ github.actor }}
password: ${{ secrets.github_token }}
Expand All @@ -86,7 +86,7 @@ jobs:
uses: hendrikmuhs/[email protected]
with:
key: ubuntu
save: ${{ ! startsWith(github.ref, 'refs/pull') }}
save: ${{ github.ref == 'refs/heads/python' }}
- name: Setup Git environment
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Get runner specifications
Expand Down
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
image: ghcr.io/espressomd/docker/ubuntu-22.04:cb0a2886ebd6a4fbd372503d7b46fc05fb1da5d5
image: ghcr.io/espressomd/docker/ubuntu-22.04:fbdf2f2f9d76b761c0aa1308f17fb17e38501850

stages:
- prepare
Expand Down Expand Up @@ -139,7 +139,7 @@ no_rotation:
fedora:36:
<<: *global_job_definition
stage: build
image: ghcr.io/espressomd/docker/fedora:3fd42369f84239b8c4f5d77067d404789c55ff44
image: ghcr.io/espressomd/docker/fedora:fbdf2f2f9d76b761c0aa1308f17fb17e38501850
variables:
with_cuda: 'false'
with_gsl: 'false'
Expand Down
5 changes: 2 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

cmake_minimum_required(VERSION 3.18)
cmake_minimum_required(VERSION 3.20)
message(STATUS "CMake version: ${CMAKE_VERSION}")
if(POLICY CMP0076)
# make target_sources() convert relative paths to absolute
Expand Down Expand Up @@ -234,8 +234,7 @@ endif()
# Python interpreter and Cython interface library
if(ESPRESSO_BUILD_WITH_PYTHON)
find_package(Python 3.9 REQUIRED COMPONENTS Interpreter Development NumPy)
# use version range 0.29.21...<3.0.0 in CMake 3.19
find_package(Cython 0.29.21 REQUIRED)
find_package(Cython 0.29.21...<3.0 REQUIRED)
find_program(IPYTHON_EXECUTABLE NAMES jupyter ipython3 ipython)
endif()

Expand Down
2 changes: 1 addition & 1 deletion cmake/FindClangTidy.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ if(CLANG_TIDY_EXE)
endif()

include( FindPackageHandleStandardArgs )
FIND_PACKAGE_HANDLE_STANDARD_ARGS( ClangTidy REQUIRED_VARS CLANG_TIDY_EXE
find_package_handle_standard_args( ClangTidy REQUIRED_VARS CLANG_TIDY_EXE
VERSION_VAR CLANG_TIDY_VERSION)
5 changes: 3 additions & 2 deletions cmake/FindCython.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ if(CYTHON_EXECUTABLE)
endif()

include(FindPackageHandleStandardArgs)
# add HANDLE_VERSION_RANGE in CMake 3.19
FIND_PACKAGE_HANDLE_STANDARD_ARGS(Cython REQUIRED_VARS CYTHON_EXECUTABLE VERSION_VAR CYTHON_VERSION)
find_package_handle_standard_args(
Cython REQUIRED_VARS CYTHON_EXECUTABLE VERSION_VAR CYTHON_VERSION
HANDLE_VERSION_RANGE)

mark_as_advanced(CYTHON_EXECUTABLE)
3 changes: 3 additions & 0 deletions maintainer/CI/dox_warnings.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@
if re.search('^no uniquely matching class member found for $', warning):
# known bug, not fixed yet
continue
if re.search('^no matching (class|file) member found for $', warning):
# known bug, not fixed yet
continue
if re.search(
'^The following parameters? of .+ (is|are) not documented:$', warning):
# non-critical warning, enforcing it would encourage bad behavior, i.e.
Expand Down

0 comments on commit 47b95a0

Please sign in to comment.