Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove idf component manager #1048

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented Sep 25, 2023

Description

Removes the idf component manager from extension's requirements.txt

Fixes #1044 #1040

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Run ESP-IDF: Configure ESP-IDF Extension
  2. Install 4.4.5 idf version
  3. No issues during setup

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested it as described above on the following os:
Windows 10, Linux and Mac

Test Configuration:

  • ESP-IDF Version: 4.4.5, 5.0, 5,1, master
  • OS (Windows,Linux and macOS): Windows, Linux, Mac

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea radurentea merged commit 296b6f6 into master Sep 26, 2023
6 checks passed
@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested:
OS - Windows 10 / MacOS
ESP-IDF: v4.4.5 / v.5.0 /v.5.1

install - build project

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails with IDF 4.4.4 and pyparsing v3.0.9 (but pyparsing v2.3.1 works!) (VSC-1191)
3 participants