[Xtensa] Fix fp16 conversion #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerekon
force-pushed
the
fp16_conversion_builtins
branch
from
8b658e8
to
22c4445
Compare
gerekon
changed the title
gerekon
force-pushed
the
fp16_conversion_builtins
branch
from
22c4445
to
25b245a
Compare
|
@andreisfr @sstefan1 PTAL |
gerekon
commented
Mar 29, 2024
|
I suggest using update_llc_test_checks.py for generating check lines. Otherwise LGTM! |
Actually I used it to generate initial test case. But after that I removed instructions and left only ones related to conversion functions calls as it is done for ARM. But looks like that code is 9 years old, so it was written before the first version of So. Ok. I will re-generate checks for easier maintenance in future. |
|
This change didn't give me the error mentioned in the issue. But, now: $> ./out/zig-x86_64-linux-musl-baseline/zig cc -target xtensa-freestanding -mcpu=esp32 start.c
LLVM Emit Object... error: <unknown>:0: Undefined temporary symbol .LBB385_2 |
gerekon
force-pushed
the
fp16_conversion_builtins
branch
from
25b245a
to
9a0907f
Compare
3 tasks
gerekon
changed the base branch from
xtensa_release_17.0.1
to
xtensa_release_18.1.2
gerekon
changed the base branch from
xtensa_release_18.1.2
to
xtensa_release_17.0.1
gerekon
force-pushed
the
fp16_conversion_builtins
branch
from
9a0907f
to
256abfe
Compare
gerekon
changed the base branch from
xtensa_release_17.0.1
to
xtensa_release_18.1.2
espressif-bot
merged commit 256abfe
into
espressif:xtensa_release_18.1.2
10 of 16 checks passed
kassane
added a commit
to kassane/zig-esp-idf-sample
that referenced
this pull request
Oct 22, 2024
with espressif/LLVM v18.1.2 - float fixed (esp32/s3) ref.: espressif/llvm-project#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.