-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(environment): Clone IDF release branches instead of downloading zip and then fastforward #274
base: main
Are you sure you want to change the base?
Conversation
4410da0
to
0f1b95a
Compare
FYI @leeebo Honestly, I’m not entirely satisfied with this approach, but given the "feature freeze" (if I understood correctly) on the Windows IDF Installer, it seems like a reasonable compromise without requiring a more complex refactor. That said, I’m open to any suggestions if you have a better approach in mind guys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would prefer to remove the code rather than adding conditions and leaving the unused code there.
By the way, do you have any benchmarks, how much time did the old approach take and how much time does the new one take? And I guess it would be good to try this from China as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c98c849
to
70a67c9
Compare
@igrr, thanks for the review! I have implemented the changes as you suggested so it should be ready to merge. I have tested the installer and it works as expected. Unfortunately, I am not able to do the merge as we agreed without your re-review and approval since you are the maintainer and requested a change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakub-kocka LGTM! Thanks!
When the selected IDF branch is the
release
one, performgit clone
instead of downloading azip
archive andfast-forwarding
to the latest commitReleated
Tested