Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IEP Update site naming convention #847

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: IEP Update site naming convention #847

merged 1 commit into from
Nov 15, 2023

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Nov 2, 2023

Description

Update site name has changed from "Espressif IDF" to "ESP-IDF Eclipse Plugin" and description has updated.

Fixes # (IEP-1086)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Use the PR update site
  • Verify that update site name has changed from "Espressif IDF" to "ESP-IDF Eclipse Plugin" and also description has updated.

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • Update site

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Nov 3, 2023

@kolipakakondal hi !

LGTM 👍

  1. Should we also change it on web page ?

image

@kolipakakondal kolipakakondal merged commit afc222d into master Nov 15, 2023
7 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1086 branch November 15, 2023 05:59
@kolipakakondal kolipakakondal added this to the v2.12.0 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants