fix(build): externalizing job name

espressif · Sep 15, 2023 · 0d8373c · 0d8373c
1 parent 63beeac
commit 0d8373c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/IDFBuildConfiguration.java b/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/IDFBuildConfiguration.java
@@ -977,7 +977,7 @@ private void processCompileCommandsFile(IConsole console, IProgressMonitor monit
 		CompileCommandsJsonParser parser = new CompileCommandsJsonParser(
 				new ParseRequest(file, new CMakeIndexerInfoConsumer(this::setScannerInformation, getProject()),
 						CommandLauncherManager.getInstance().getCommandLauncher(this), console));
-		Job parseJob = new Job("Parse Compile Commands File") //$NON-NLS-1$
+		Job parseJob = new Job(Messages.IDFBuildConfiguration_ParseCommand)
 		{
 			protected IStatus run(IProgressMonitor monitor)
 			{

diff --git a/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/Messages.java b/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/Messages.java
@@ -23,6 +23,7 @@ public class Messages extends NLS
 	public static String CMakeBuildConfiguration_Failure;
 	public static String CMakeErrorParser_NotAWorkspaceResource;
 	public static String IDFBuildConfiguration_CMakeBuildConfiguration_NoToolchainFile;
+	public static String IDFBuildConfiguration_ParseCommand;
 	public static String IncreasePartitionSizeTitle;
 	public static String IncreasePartitionSizeMessage;
 

diff --git a/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties b/bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/messages.properties
@@ -15,6 +15,7 @@ CMakeBuildConfiguration_ProcCompJson=Processing compile_commands.json
 CMakeBuildConfiguration_Failure=Failure running cmake: %s\n
 CMakeErrorParser_NotAWorkspaceResource=Could not map %s to a workspace resource. Did the build run in a container?
 IDFBuildConfiguration_CMakeBuildConfiguration_NoToolchainFile=No toolchain file found
+IDFBuildConfiguration_ParseCommand=Parse Compile Commands File
 IncreasePartitionSizeTitle=Low Application Partition Size
 IncreasePartitionSizeMessage=Less than 30% of application partition size is free({0} of {1} bytes), would you like to increase it? Please click <a href={2}>here</a> to check more details.
 ToolsInitializationDifferentPathMessageBoxTitle=Different IDF path found in the config file