Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HA standard wind speed sensor device default config value (TZ-1214) #451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lboue
Copy link

@lboue lboue commented Oct 13, 2024

Description

Add HA standard wind speed sensor device default config value
Add Zigbee HA standard wind speed sensor clusters

Related

Zigbee Wind speed sensor example #10455

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Add HA standard wind speed sensor device default config value
@lboue lboue changed the title Update esp_zigbee_ha_standard.h Add HA standard wind speed sensor device default config value Oct 13, 2024
@github-actions github-actions bot changed the title Add HA standard wind speed sensor device default config value Add HA standard wind speed sensor device default config value (TZ-1214) Oct 13, 2024
@lboue lboue marked this pull request as ready for review October 15, 2024 09:37
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lboue PTAL

lboue and others added 2 commits October 27, 2024 12:09
Zigbee HA standard wind speed sensor clusters
@lboue
Copy link
Author

lboue commented Oct 27, 2024

Thanks @P-R-O-C-H-Y. I applied requested changes. Is it OK now?

@xieqinan
Copy link
Contributor

Hi @lboue,

It appears that the wind speed sensor does not align with the standard HA devices defined by the Zigbee Home Automation Profile. Could you please provide more details for reference?

@lboue
Copy link
Author

lboue commented Oct 30, 2024

@xieqinan There is a Wind Speed Measurement cluster for described in 07-5123-08-Zigbee-Cluster-Library.pdf Page 4-51.

image

@xieqinan
Copy link
Contributor

@lboue

The Wind Speed Measurement cluster is a standard cluster defined by the ZCL specification, but it’s not a standard device type within the Zigbee Home Automation Public Application Profile. I suggest defining this structure within your project first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants