Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI Release Tweak (IDFGH-7584) #9141

Closed
wants to merge 1 commit into from
Closed

SPI Release Tweak (IDFGH-7584) #9141

wants to merge 1 commit into from

Conversation

meawoppl
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 12, 2022
@github-actions github-actions bot changed the title SPI Release Tweak SPI Release Tweak (IDFGH-7584) Jun 12, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@suda-morris suda-morris requested a review from ginkgm June 13, 2022 02:28
@meawoppl
Copy link
Contributor Author

@cibomahto got a second to synopsize?

@Maksons
Copy link

Maksons commented Jun 14, 2022

@meawoppl
Sorry, question from side viewer:
Could you descripe idea behind this patch?

@KaeLL
Copy link
Contributor

KaeLL commented Jun 14, 2022

@Maksons seconded. What's the goal here?

@negativekelvin
Copy link
Contributor

Possibly to reduce overhead by not calling xQueueSendFromISR and not yielding

@meawoppl
Copy link
Contributor Author

Apologies, this is @cibomahto 's work, I was just trying to be helpful by making a PR of it. I think he will chime in shortly.

@KaeLL
Copy link
Contributor

KaeLL commented Jun 17, 2022

I think @negativekelvin is right.
This is a good one. Will test it later. Nice job, @cibomahto.

@KaeLL
Copy link
Contributor

KaeLL commented Jul 8, 2022

@ginkgm care to take a look?

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Jul 11, 2022
@ginkgm
Copy link
Collaborator

ginkgm commented Jul 11, 2022 •
edited
Loading

This is a good one, I think we will accept this

Thanks for contribution

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Selected for Development Issue is selected for development labels Jul 11, 2022
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: In Progress Work is in progress labels Jul 25, 2022
@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginkgm ginkgm Awaiting requested review from ginkgm

Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@meawoppl @CLAassistant @Alvin1Zhang @Maksons @KaeLL @negativekelvin @ginkgm @espressif-bot