Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored return value. (IDFGH-4976) #6768

Closed
wants to merge 1 commit into from

Conversation

bugadani
Copy link
Contributor

sdio_ringbuf_send ignores the return value of the callback.

sdio_ringbuf_send ignores the return value of the callback.
@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 23, 2021
@github-actions github-actions bot changed the title Fix ignored return value. Fix ignored return value. (IDFGH-4976) Mar 23, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@Alvin1Zhang Alvin1Zhang requested a review from ginkgm March 24, 2021 01:35
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels May 5, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution, and sorry for late reply, we have put the changes into our internal review queue, and the PR will be updated once the changes are available on GitHub. Thanks.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels May 13, 2021
espressif-bot pushed a commit that referenced this pull request May 17, 2021
sdio_ringbuf_send ignores the return value of the callback.

Merges #6768
@igrr
Copy link
Member

igrr commented May 17, 2021

The fix has been cherry-picked as c8b697a, thanks again for the PR @bugadani!

@igrr igrr closed this May 17, 2021
@bugadani bugadani deleted the patch-2 branch May 17, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants