Implemented esp_core_dump_image_erase() (IDFGH-4832) #6631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now returns ESP_ERR_NOT_FOUND when partition is blank
github-actions
bot
changed the title
|
Thanks for your contribution. |
KaeLL
reviewed
Mar 2, 2021
gerekon
approved these changes
Mar 2, 2021
o-marshmallow
suggested changes
Mar 3, 2021
| * | ||
| * @return ESP_OK on success, otherwise \see esp_err_t | ||
| */ | ||
| esp_err_t esp_core_dump_image_erase(); |
There was a problem hiding this comment.
Please, can you explicitly put void in the parenthesis to forbid passing arguments to the function?
|
anything I can do for this PR? |
|
Hello @0xFEEDC0DE64 , Sorry for the delay (again), your PR has been accepted and is currently passing internal reviews. Once merged, it will be synced to Github after passing the internal tests. |
espressif-bot
added
Resolution: Done
projectgus
pushed a commit
that referenced
this pull request
Jun 30, 2021
…mage_get() now returns ESP_ERR_NOT_FOUND when partition is blank Closes #6631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented esp_core_dump_image_erase() and esp_core_dump_image_get() now returns ESP_ERR_NOT_FOUND when partition is blank/erased.
esp_core_dump_image_erase() calls esp_partition_erase_range() and additionally writes size 0xFFFFFFFF to avoid problems when flash encryption is enabled. Without explicitly writing 0xFFFFFFFF for size, esp_core_dump_image_get() will read a garbage size when the erased bytes are being decrypted.
With size 0xFFFFFFFF esp_core_dump_image_get() now returns ESP_ERR_NOT_FOUND instead of ESP_ERR_INVALID_SIZE
I needed to know if an error happened during reading the coredump or if it has simply been not found / been invalid or erased (because never crashed or coredump has been transmitted already successfully)