Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selection of different core for main task (IDFGH-4828) #6627

Closed
wants to merge 2 commits into from
Closed

Allow selection of different core for main task (IDFGH-4828) #6627

wants to merge 2 commits into from

Conversation

0xFEEDC0DE64
Copy link
Contributor

This solved my idle task core0 watchdog timeout warnings in serial console.

@github-actions github-actions bot changed the title Allow selection of different core for main task Allow selection of different core for main task (IDFGH-4828) Feb 27, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@KaeLL
Copy link
Contributor

KaeLL commented Mar 1, 2021

Great patch, btw. But have you found out why you're having this issue when app_main's running on core0?

projectgus
projectgus suggested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@projectgus projectgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a useful change for some folks! I have a couple of minor cleanup requests, but happy to add this config item.

components/esp_common/Kconfig Outdated Show resolved Hide resolved
components/freertos/port/port_common.c Outdated Show resolved Hide resolved
@projectgus
Copy link
Contributor

Hi @0xFEEDC0DE64,

Thanks for the fast update! I've squashed these commits and cherry-picked them into our internal review and merge queue. This PR will be updated once this is merged.

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaeLL KaeLL KaeLL left review comments

@projectgus projectgus projectgus approved these changes

Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xFEEDC0DE64 @Alvin1Zhang @KaeLL @projectgus @espressif-bot