Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed c++ include usage for esp_core_dump.h (IDFGH-4782) #6585

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

0xFEEDC0DE64
Copy link
Contributor

No description provided.

@github-actions github-actions bot changed the title Fixed c++ include usage for esp_core_dump.h Fixed c++ include usage for esp_core_dump.h (IDFGH-4782) Feb 20, 2021
@igrr
Copy link
Member

igrr commented Feb 20, 2021

Thanks @0xFEEDC0DE64 for submitting a fix to #6583. One extra request, could you please remove components/espcoredump/include/esp_core_dump.h from tools/ci/check_public_headers_exceptions.txt?

@0xFEEDC0DE64
Copy link
Contributor Author

Are any questions open? Can I help somehow to get this merged?

@o-marshmallow
Copy link
Collaborator

Hello @0xFEEDC0DE64 ,

Sorry for the long delay in getting back to you and many thanks for being patient. This PR has been merged internally and will be synced to Github once our tests pass.

@espressif-bot espressif-bot merged commit c179ece into espressif:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants