Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cert/key length options to esp_http_client (IDFGH-4752) #6556

Closed
wants to merge 1 commit into from
Closed

Add cert/key length options to esp_http_client (IDFGH-4752) #6556

wants to merge 1 commit into from

Conversation

0xFEEDC0DE64
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Added cert and key length options Added cert and key length options (IDFGH-4752) Feb 16, 2021
@Alvin1Zhang
Copy link
Collaborator

@0xFEEDC0DE64 Thanks for your contribution.

@0xFEEDC0DE64 0xFEEDC0DE64 changed the title Added cert and key length options (IDFGH-4752) Add cert/key length options to esp_http_client (IDFGH-4752) Feb 18, 2021
@0xFEEDC0DE64
Copy link
Contributor Author

Ok is this PR already in consideration? Are any questions open? Can I help somehow to get this merged?

@shubhamkulkarni97
Copy link
Contributor

Hi @0xFEEDC0DE64,
This PR is in consideration, I'll update when it gets merged internally. Thanks

@shubhamkulkarni97
Copy link
Contributor

@0xFEEDC0DE64 Could you share the context in which this fix is required? Or an example that fails without this fix?

@0xFEEDC0DE64
Copy link
Contributor Author

my keys are coming from an encrypted partition and are not necessary 0-terminated. I applied the same api as for other client key auth parameters in esp-idf. Do you think it is not useful to specify the length in advance and skip an unnessecary strlen?

@espressif-bot espressif-bot added the Status: Done Issue is done internally label Mar 23, 2021
@shubhamkulkarni97
Copy link
Contributor

@0xFEEDC0DE64 Changes from this PR are merged internally. These changes will be available on GitHub once all internal checks are passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamkulkarni97 shubhamkulkarni97 shubhamkulkarni97 approved these changes

Assignees
No one assigned
Labels
Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xFEEDC0DE64 @CLAassistant @Alvin1Zhang @shubhamkulkarni97 @espressif-bot