add FATFS_TINY menuconfig item #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
suggested changes
Aug 30, 2017
| @@ -105,4 +105,19 @@ config FATFS_MAX_LFN | |||
| help | |||
| Maximum long filename length. Can be reduced to save RAM. | |||
|
|
|||
| choice FATFS_TINY | |||
| prompt "Use per-file caches" | |||
There was a problem hiding this comment.
Good catch noticing this option!
Could you please make this a "bool" option CONFIG_FATFS_PER_FILE_CACHES rather than a "prompt"? Can do the necessary inverting of logic (tiny mode == !per file caches) in the header file if necessary.
|
@edmund-huber are you still working on this? Are you able to make the requested change? |
|
Thanks for checking. I am on vacation abroad currently and don't have the means to make or test any change. I'll be back later this week and can do it then. |
|
Support for FATFS_TINY has been added in 07c44d7 (as "Use separate cache for each file"). Thanks for bringing this feature to our attention, @edmund-huber . |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
_FS_TINYsaves4096 bytes * max_filesof heap. This makes a big difference for us!