Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freertos_hooks: Fix unbalance lock in deregistration for cpu functions (IDFGH-4472) #6275

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

AxelLin
Copy link
Contributor

@AxelLin AxelLin commented Dec 16, 2020

Current code exits the deregistration for cpu functions with spinlock held when
cpuid >= portNUM_PROCESSORS. Fix it.

Fixes: 9d63e1d ("New Task Watchdog API (Revert of Revert)")
Signed-off-by: Axel Lin [email protected]

Current code exits the deregistration for cpu functions with spinlock held when
cpuid >= portNUM_PROCESSORS. Fix it.

Fixes: 9d63e1d ("New Task Watchdog API (Revert of Revert)")
Signed-off-by: Axel Lin <[email protected]>
@Alvin1Zhang
Copy link
Collaborator

Alvin1Zhang commented Dec 16, 2020

Thanks for your contribution

@mahavirj mahavirj self-requested a review December 18, 2020 06:04
@github-actions github-actions bot changed the title freertos_hooks: Fix unbalance lock in deregistration for cpu functions freertos_hooks: Fix unbalance lock in deregistration for cpu functions (IDFGH-4472) Dec 21, 2020
@projectgus projectgus self-requested a review January 4, 2021 02:47
Copy link
Contributor

@projectgus projectgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this @AxelLin . I've submitted this to our internal review and merge queue.

@espressif-bot espressif-bot merged commit 16291ba into espressif:master Jan 15, 2021
@AxelLin AxelLin deleted the freertos_hooks-fix-locking branch January 16, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants